rapids-single-cell-examples icon indicating copy to clipboard operation
rapids-single-cell-examples copied to clipboard

Published 20 hours ago • verified publisher icon NVIDIA-Genomics-Research

rank_genes_groups fix

Open Intron7 opened this issue 3 years ago • 1 comments

Dear all,

I fixed the rank_genes_groups function. However I change quit a bit of the preprocessing e.g. masking from cupy to numpy. In the notebooks that I was able to test (so not the 1Million cell notebooks) this didn't negatively impact performance. I might have even sped it up a bit. However I don't know if this will be the case even for the 1 Million cells notebooks. So you might want to test this first before merging. I also changed the the input so that it now uses the adata object with a groupby variable that takes an .obs column. If you want me to I can also include GPU functions for diffusion maps and draw_graph (force atlas 2).

Intron7 avatar Feb 01 '22 13:02 Intron7

I was just able to confirm that this version is a lot faster than the version in the newest release. On my A100 80GB It runs in 1m 4 sec vs 1m 51 sec. It also avoids some errors that are still present and in the publication.

Intron7 avatar Jun 03 '22 10:06 Intron7

@Intron7, I know it's been awhile since you've opened this PR. If you can fix the merge conflicts here then I'll give it a review.

cjnolet avatar Nov 30 '22 15:11 cjnolet