GenomeWorks icon indicating copy to clipboard operation
GenomeWorks copied to clipboard

format.h is broken and breaks CUDA compile

Open cement-head opened this issue 4 years ago • 3 comments

There's a misplaced set of quotes in format.h file that prevents CUDA integration into RAVEN (error2 build fail).:

This showed up when I was trying to compile RAVEN for CUDA in </raven/build/_deps/genomeworks-src/3rdparty/spdlog/include/spdlog/fmt/bundled/format.h>

Pulled solution from here: https://www.gitmemory.com/issue/yuzu-emu/yuzu/2597/507715224

Changed Line 3475 from: FMT_CONSTEXPR internal::udl_formatter<Char, CHARS...> operator""_format() {

To (remove quotes): FMT_CONSTEXPR internal::udl_formatter<Char, CHARS...> operator_format() {

cement-head avatar Feb 24 '21 11:02 cement-head

Hi @cement-head , thanks for reporting this issue! I think this problem will be fixed in the upcoming release, since we removed the spdlog dependency in a711fca15585196b15e5eafae6c7cf4ad3903df0 . Is it ok if I ask you to verify once the release is out?

ahehn-nv avatar Feb 24 '21 12:02 ahehn-nv

Yes please! @andorjkiss

cement-head avatar Feb 24 '21 14:02 cement-head

The new release is out: https://github.com/clara-parabricks/GenomeWorks/releases/tag/v2021.02.0 Could you give it another try with that release and check if the problem got fixed?

ahehn-nv avatar Feb 25 '21 14:02 ahehn-nv