GenomeWorks
GenomeWorks copied to clipboard
format.h is broken and breaks CUDA compile
There's a misplaced set of quotes in format.h file that prevents CUDA integration into RAVEN (error2 build fail).:
This showed up when I was trying to compile RAVEN for CUDA in </raven/build/_deps/genomeworks-src/3rdparty/spdlog/include/spdlog/fmt/bundled/format.h>
Pulled solution from here: https://www.gitmemory.com/issue/yuzu-emu/yuzu/2597/507715224
Changed Line 3475 from: FMT_CONSTEXPR internal::udl_formatter<Char, CHARS...> operator""_format() {
To (remove quotes): FMT_CONSTEXPR internal::udl_formatter<Char, CHARS...> operator_format() {
Hi @cement-head , thanks for reporting this issue! I think this problem will be fixed in the upcoming release, since we removed the spdlog dependency in a711fca15585196b15e5eafae6c7cf4ad3903df0 . Is it ok if I ask you to verify once the release is out?
Yes please! @andorjkiss
The new release is out: https://github.com/clara-parabricks/GenomeWorks/releases/tag/v2021.02.0 Could you give it another try with that release and check if the problem got fixed?