OpenDiT icon indicating copy to clipboard operation
OpenDiT copied to clipboard

Reproduction of DiT

Open WZDTHU opened this issue 11 months ago • 6 comments

Thank you for your great work, and I have several issues:

First, I think this work is definitely going to improve the DiT training more efficiently. But I wonder whether this codebase could reproduce the results in the original DiT paper, such as FID. image

Second, I observed that global seed is used in the training of the original DiT implementation, as follows. In your implementation, global seed is not used in the train.py. Would this affect the reproducibility? image

WZDTHU avatar Feb 29 '24 12:02 WZDTHU

  1. We have verified our accuracy on ImageNet. And we can achieve similar generation qualiy as the origin DiT. I think thats enough for us. We are now using our framework to train text-to-video models, which is more valuable for the current time being.
  2. Seed will be always set in our framework when we launch.

oahzxl avatar Feb 29 '24 15:02 oahzxl

@oahzxl Could you further add the FID you obtain and corresponding training steps with this repo into the README? I think that will be more attractive for people want to understand more about it. Thanks anyway, really good job.

xyzhang626 avatar Mar 01 '24 10:03 xyzhang626

currently all of our resources is used for training video generation models. so maybe in future we will update our results on FID

oahzxl avatar Mar 01 '24 11:03 oahzxl

Thanks for your rapid reply. I still feel puzzled about the global seed in OpenDiT/train.py. As in the following figure, global_seed is only seen in add_argument(). How does this seed be set in your framework? If I misunderstand the usage, could you provide more instructions? Thank you.

image

WZDTHU avatar Mar 01 '24 14:03 WZDTHU

it will be set in colossai.launch. thanks for your suggestion, i will pass this arg to our launch func in future pr

oahzxl avatar Mar 01 '24 14:03 oahzxl

We have already enabled passing the global seed during launch time, please check the latest commit! Thanks for your patience!

KKZ20 avatar Mar 06 '24 07:03 KKZ20

Thanks for your attention and reply.

WZDTHU avatar Mar 16 '24 08:03 WZDTHU