misp
misp copied to clipboard
Add configuration for HTTP port and HTTPS
Add configuration options to the container to allow the port MISP listens on to be set, and allow HTTPS to be enabled. Add a volume point to allow certificates for HTTPS to be volumed in.
I would recommend to use a reverse proxy like Nginx or Traefik for TLS termination instead of terminate TLS directly in the MISP container. I also don't see the need to make the HTTP listening port configurable because you can map the port to any host port you want.
In our setup, we have our reverse proxy running on a separate system, and so we wanted to have the traffic flowing over the (albeit internal) network be encrypted, even if the actual TLS termination is done by the reverse proxy. I realized this is a somewhat uncommon use case, and so feel free to reject this if you don't think it would be useful to others, but it is a set-up in use.
I added the port configurability just so that we wouldn't be confusingly serving HTTPS over port 80 on the container, even if we could re-map the host port.
I think you could juste add mod_ssl in your docker build and everybody could choise if they want to use https or a revers proxy. Is it possible to add this in your future release?