update-homebrew-formula-action icon indicating copy to clipboard operation
update-homebrew-formula-action copied to clipboard

If homebrew name is not equal to repository name, bottle detection fails

Open reckter opened this issue 3 years ago • 1 comments

Hey :wave:

If the name of the formula is different than the name of the github repository (say "something" for forumla and "something-cli" for the github repository), the bottles are not correctly picked up.

The workaround that I've found: set the asset_name to something-cli-.... instead ofsomething-....).

I would suggest adding that to the documentation and/or adding a "name" argument, in order to have it overridable, if needed.

see the repo.name section in the line below

https://github.com/NSHipster/update-homebrew-formula-action/blob/76c92ced34e90da0c58528807111bc9bcad09235/entrypoint.rb#L76

reckter avatar Aug 30 '21 19:08 reckter

Actually, the workaround doesn't work. It is still uploaded to the artifacts as something-cli-1.0...., but brew does try to download something-1.0....

reckter avatar Aug 31 '21 08:08 reckter