flasc icon indicating copy to clipboard operation
flasc copied to clipboard

Feature/detect yaw shift

Open paulf81 opened this issue 1 year ago • 0 comments

This is not ready to merge, just wanted to share the main concept

Feature or improvement description The pr adds a new file turbine_analysis/detect_yaw_change.py based on approaches suggested by @ejsimley which implements a method for detecting sudden shifts in the northing calibration of yaw angle. The approach is based on cusum change detection one example here. The pr addresses Issue #106

Note this is built on the ruff branch/pr (PR #143 ) so appears to have many more file changes then it actually does. Once that is merged to develop.

Still some way to go on this but main ideas of next steps:

  • [ ] Do @ejsimley , @misi9170 , @Bartdoekemeijer like the approach?
  • [ ] Should we add cleverness about looping several times for multiple shifts or lean on repeated calls?
  • [ ] Should we look to correct wd with yaw?
  • [ ] Should I convert to polars for speed? Lots of memory stuff, copying etc,
  • [ ] I think the circular median would do a better job than the mean, but this is hard to find existing and not straightforward to implement
  • [ ] Add tests
  • [ ] Add examples

Related issue, if one exists Closes #106

Impacted areas of the software turbine_analysis/detect_yaw_change.py

paulf81 avatar Dec 14 '23 20:12 paulf81