bifacialvf icon indicating copy to clipboard operation
bifacialvf copied to clipboard

Change "facing west" criterion to allow small uncertainty in `sazm`

Open kandersolar opened this issue 7 months ago • 2 comments

Closes #61

Using the same reproducer as #61 with this branch, the swapping is gone:

image

Disclaimer: I'm not very familiar at all with bifacialvf and have not evaluated the suitability of this fix beyond making the above plot.

kandersolar avatar Jun 10 '25 15:06 kandersolar

Test failure seems unrelated.

kandersolar avatar Jun 10 '25 15:06 kandersolar

See my comment - I think checking the sign of sine is a more robust solution.

mikofski avatar Jun 11 '25 20:06 mikofski