alfalfa
alfalfa copied to clipboard
Add Test - breaking OSW that strands us in "starting"
https://github.com/NREL/alfalfa/blob/develop/tests/integration/test_refrig_case_osw.py#L34 This test enters STARTING
but then immediately triggers an error. It then makes sure that the run enters ERROR
state instead of staying in STARTING
. It's not exactly a broken OSW, but it's an error in the same state.
I really like that you added this… this is an error due to bad inputs to start
? I also want to add OSWs that error at different stages. I actually have them, I just didn’t get the test set up. Will follow this pattern to add it.
From: Tobias Shapinsky @.> Date: Friday, July 1, 2022 at 1:50 PM To: NREL/alfalfa @.> Cc: Petersen, Anya @.>, Assign @.> Subject: Re: [NREL/alfalfa] Add Test - breaking OSW that strands us in "starting" (Issue #290)
CAUTION: This email originated from outside of NREL. Do not click links or open attachments unless you recognize the sender and know the content is safe.
https://github.com/NREL/alfalfa/blob/develop/tests/integration/test_refrig_case_osw.py#L34https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNREL%2Falfalfa%2Fblob%2Fdevelop%2Ftests%2Fintegration%2Ftest_refrig_case_osw.py%23L34&data=05%7C01%7Canya.petersen%40nrel.gov%7C4ca56ea8a0684bcf55f208da5b9af627%7Ca0f29d7e28cd4f5484427885aee7c080%7C0%7C0%7C637923018377610984%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9ejLZz2epfTsyon0N9WzPyvDHo31u1p58KpoJ0L%2FUWo%3D&reserved=0 This test enters STARTING but then immediately triggers an error. It then makes sure that the run enters ERROR state instead of staying in STARTING. It's not exactly a broken OSW, but it's an error in the same state.
— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNREL%2Falfalfa%2Fissues%2F290%23issuecomment-1172667773&data=05%7C01%7Canya.petersen%40nrel.gov%7C4ca56ea8a0684bcf55f208da5b9af627%7Ca0f29d7e28cd4f5484427885aee7c080%7C0%7C0%7C637923018377610984%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wIR2qtBDkepVKRtyNOhbDy5ge9L5jXARyBxQi9Ig%2FtA%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAABN4C7A4TPSRAJZ4ADQ7B3VR5DYTANCNFSM5TONYPPQ&data=05%7C01%7Canya.petersen%40nrel.gov%7C4ca56ea8a0684bcf55f208da5b9af627%7Ca0f29d7e28cd4f5484427885aee7c080%7C0%7C0%7C637923018377610984%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=SXONbWsb%2FrBt28dP2q97czhJBH4YwKdjml6mez9Oeso%3D&reserved=0. You are receiving this because you were assigned.Message ID: @.***>