JSON-Viewer icon indicating copy to clipboard operation
JSON-Viewer copied to clipboard

Review new PRs. Fix "Show JSON Viewer" docking panel

Open AntonDevil opened this issue 3 months ago • 2 comments

Hi @SinghRajenM

I have created a couple of PRs for JSONViewer Notepad++ plugin. I see that you're the only contributor who was active lately, so maybe you can help me with reviews and merges 😊?

It's all started with the fact that "Show JSON Viewer" feature does show a docking panel with parsed JSON but the panel is inactive, half visible and is basically broken (but I do see the content of JSON in it). NPPJSONViewer v2.1.1.0

Preview of what I see: Notepad++ v8.8.6 (64-bit) Build time: Oct 7 2025 - 13:44:28 Scintilla/Lexilla included: 5.5.7/5.4.5 Boost Regex included: 1_85 Image

I decided to take a look and fix that. Turned out that the problem stems from outdated plugintemplate files which are copied into local external/npp

~~The simplest fix is to update just the DockingDlgInterface.h - uncomment parameter in virtual INT_PTR CALLBACK run_dlgProc(UINT message, WPARAM /*wParam*/, LPARAM lParam) on line DockingDlgInterface.h:74. I guess commented parameter messes up the virtual table or how virtual function calls are resolved.~~

Anyways, I went further and decided to update all external/npp files.

I have 2 options for the fix (see which one you like more. I personally prefer the 2nd option (submodule)):

  1. #222 Here I just update all external/npp files and fix JSONViewer code where needed
  2. #223 Alternative version where I remove all external/npp files and take dependency on plugintemplate as git submodule

Also, maybe you can add me as a Collaborator 😊?

AntonDevil avatar Oct 12 '25 21:10 AntonDevil