JSON-Viewer
JSON-Viewer copied to clipboard
Migrate from copies from external plugintemplate to git submodules
Currently, JSONViewer includes files from plugintemplate directly copied into external/npp This PR removes these copies and migrates these dependencies to git Submodules like all other existing dependencies
Updates cause by move to submodules:
- Added plugintemplate into .gitmodules
- Added proxy files (forwarding headers/sources) to
\src\NppJsonViewer\plugintemplatefolder for ease of use as done in Docking_Dialogue_Interface alternative template mentioned in official How to develop a plugin - Updated
ExternalIncludePathinNppJsonViewerCommon.propsto include newNppJsonViewer\plugintemplatefolder$(SolutionDir)..\external\npp;->$(SolutionDir)NppJsonViewer\plugintemplate; - Fixed includes to follow new folder structure because some files are now in
DockingFeaturesubfolder Updated in:AboutDlg.h,JsonViewDlg.h,SettingsDlg.h - Sorted files in
NPPJSONViewer.vcxprojandNPPJSONViewer.vcxproj.filtersin lexicographical order (ignoring case) Movedplugintemplate\files to the bottom since they are not a direct part of main project
Updates cause by plugintemplate update:
- Replaced DEPRECATED
NPPM_ADDTOOLBARICONwithNPPM_ADDTOOLBARICON_FORDARKMODEinNppJsonPlugin.cppreusing samem_hMenuIcon.hToolbarIconfortoolbarIconsWithDarkModefor dark mode - Replaced DERPECATED
NPPM_GETENABLETHEMETEXTUREFUNCwith direct call toEnableThemeDialogTextureinSettingsDlg.cpp - Added
uxtheme.libasAdditionalDependenciestoNPPJSONViewer.vcxprojto link newly addedEnableThemeDialogTexture - Removed! unused
URLCtrl.handURLCtrl.cpp. They are not part of plugintemplate
References:
This is an alternative to #222