cfe icon indicating copy to clipboard operation
cfe copied to clipboard

Published 20 hours ago • verified publisher icon NOAA-OWP

Variable name is wrong; in the result baseflow is not generated

Open RY4GIT opened this issue 1 year ago • 0 comments

This issue is identified in PR https://github.com/NOAA-OWP/cfe/pull/60 and https://github.com/NOAA-OWP/cfe/pull/63

Current behavior

Variable names were inconsistent. Fluxes from both soil & groundwater storages were named as primary_flux and secondary_flux in the main execusion vs. primary_flux**_m** and secoundary_flux**_m** in conceptual_reservoir_flux_calc.

As a result, the baseflow was entirely missing in CFE. Fluxes calculated in conceptual_reservoir_flux_calc were not passed the main flux calculation.

Change needed

  • Change variable name 'primary_flux' to 'primary_flux_m'
  • Change variable name 'secondary_flux' to 'secondary_flux_m'

RY4GIT avatar Apr 05 '23 20:04 RY4GIT