cfe icon indicating copy to clipboard operation
cfe copied to clipboard

BMI Update may incorrectly assume a 1 hour time step

Open hellkite500 opened this issue 3 years ago • 10 comments

The Update function assumes a conversion of the precip variable from mm/hr to m/hr by simply accounting for the scale difference between mm and m. However, what happens when update_until modifies the dt for whatever reason to a fractional dt. Is this conversion/assumption still valid? A quick look through the model definitions implies that precipitation should be the value for the timestep -- timestep_rainfall_input_m. Just want to double check that there is nothing untoward happening here.

https://github.com/NOAA-OWP/cfe/blob/3617bda7b887ca283a971cc630fd76d890292db1/src/bmi_cfe.c#L970

hellkite500 avatar Nov 16 '21 22:11 hellkite500