cfe
cfe copied to clipboard
When used via BMI, precip should NOT be scaled any further
https://github.com/NOAA-OWP/cfe/blob/0b488a123887100c6304aee3b0149bc97a68283e/src/bmi_cfe.c#L1509C7-L1509C81
During the update step, precip is scaled by 1000 assuming the prcipitation input variable has units of mm/hr
which is NOT a valid assumption when precip is coming from a BMI input variable. For example, when copuled with NOM and passing QINSUR
as the surface flux, then the forcing comes in the units of m/s
.
Also, when used via a framework which uses BMI unit data to perform unit conversion, this becomes prolematic, as the advertised unit of the precip input variable is mm/hr
and so, as in the example with NOM, a converting framework will pass in values with the correct units, and they are then divided by 1000.