GFDL_atmos_cubed_sphere icon indicating copy to clipboard operation
GFDL_atmos_cubed_sphere copied to clipboard

Typo/bug in fv_grid_tools.F90 in dev/emc branch when print out grid corner indexes and locations

Open BinLiu-NOAA opened this issue 10 months ago • 2 comments

Describe the bug There is a typo/bug in fv_grid_tools.F90 when print out the grid SW, NW, NE, SE CORNER indexes and lat/lon locations. The source code lines of ic = p_ind(1,1,1) ; jc = p_ind(1,1,1) should be updated into: ic = p_ind(1,1,1) ; jc = p_ind(1,1,2) so that the jc gets the correct index. Otherwise, jc is always identical to ic, leading to wrong printout jc and lat/lon locations for the grid corners.

Additional context This bug/typo was found/identified when checking UFS-HAFS moving-nesting forecast log. And you can see an proposed/example fix from this commit 4162fad.

BinLiu-NOAA avatar Apr 09 '24 00:04 BinLiu-NOAA

Sorry for the delay @BinLiu-NOAA . I think you are correct. Could you go ahead and create an MR?

Thanks, Lucas

lharris4 avatar May 07 '24 15:05 lharris4

Sorry for the delay @BinLiu-NOAA . I think you are correct. Could you go ahead and create an MR?

Thanks, Lucas

Thanks, @lharris4! PR #341 has been created accordingly to address this issue.

BinLiu-NOAA avatar May 13 '24 02:05 BinLiu-NOAA

merged into dev/emc branch with PR #341

bensonr avatar Jun 25 '24 17:06 bensonr