FMS icon indicating copy to clipboard operation
FMS copied to clipboard

Published 20 hours ago • verified publisher icon NOAA-GFDL

Coupler CI

Open rem1776 opened this issue 2 years ago • 6 comments

Description Adds a second job to test compilation of the coupler with PRs.

This will fail until https://github.com/NOAA-GFDL/FMScoupler/pull/75 goes in.

How Has This Been Tested? Tested on my forks

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] New check tests, if applicable, are included
  • [x] make distcheck passes

rem1776 avatar May 04 '22 20:05 rem1776

@rem1776 is there a way to run/trigger the coupler tests with a PR to main in FMS?

underwoo avatar May 05 '22 18:05 underwoo

@rem1776 is there a way to run/trigger the coupler tests with a PR to main in FMS?

It can potentially be enabled for PR's too, but since the coupler tests are running in a different repo the status cannot be checked from the FMS site. To get past that the coupler CI will create an issue if it fails from an FMS trigger which I figured shouldn't happen for PR's, so that's why it ended up being just main pushes.

rem1776 avatar May 05 '22 19:05 rem1776

I'm gonna simplify this and just add the coupler build test to the FMS CI and run on PRs after the normal testing suite.

rem1776 avatar May 20 '22 15:05 rem1776

We can add model tests on parallel works too if that would help, but those also require more resources.

thomas-robinson avatar May 20 '22 15:05 thomas-robinson

I don't think this worked like you hoped it would. FMS got cloned/checked out. Then coupler was cloned and then:

Run t/null_model_build.sh
  t/null_model_build.sh
  shell: sh -e {0}
Cloning into 'mkmf'...
Cloning into '/__w/FMS/FMS/t/null.O0meQo/src/FMS'...

It looks like it got it's own clone of FMS main https://github.com/NOAA-GFDL/FMScoupler/blob/c12af876d4baef20346db8391422b6b6df209c75/t/null_model_build.sh#L26-L27

thomas-robinson avatar May 20 '22 17:05 thomas-robinson

@thomas-robinson I'll put another PR in for the coupler have the test script take a SHA to checkout as an optional argument. I'll probably try to see if I can get it actually running as well instead of just compiling.

rem1776 avatar May 20 '22 17:05 rem1776