FMS icon indicating copy to clipboard operation
FMS copied to clipboard

Removing unused arguments throughout FMS

Open rem1776 opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. There's a couple routines throughout FMS that have required or optional arguments that are entirely unused. Some seem to be from an initial mistake, and others are from trying to match older routines' arguments. For public routines, should these be removed, or slowly depracated?

Describe the solution you'd like remove the arguments (if mainly used internally)

Describe alternatives you've considered deprecate the arguments and throw an error or warning if misused for now

Additional context

rem1776 avatar Sep 16 '21 17:09 rem1776

List of public routines with unused arguments to deprecate and remove(will be added to):

  • fms2_io/fms_io_utils.F90, get_mosaic_tile_file_sg: is_no_domain
  • fms2_io/register_*_attribute.inc, register_*_attribute routines: str_len
  • axis_utils.F90, get_axis_bounds: axes
  • horiz_interp_bicubic.F90, horiz_interp_bicubic: mask_in, missing_value, missing_permit (replaced by horiz_interp_bicubic_new)
  • horiz_interp.F90, horiz_interp_new_1d: mask_in, mask_out
  • horiz_interp_spherical_wght: mask_out
  • horiz_interp_conserve.F90: verbose parameter for most routines
  • astrology.F90, annual_mean_solar_2d: js, je
  • xgrid.F90, conservation_check_side1(+ug): grid_id

rem1776 avatar Oct 14 '21 14:10 rem1776

@rem1776 I think you can ignore any diag_output routines as they are being taken care of in the diag_manager io clean up.

uramirez8707 avatar Oct 14 '21 15:10 uramirez8707

This isn't an argument, but we could probably remove found_neighbors from horiz_interp_type as part of this ( discussion in https://github.com/NOAA-GFDL/FMS/pull/1100#discussion_r1072623505 )

rem1776 avatar Jan 19 '23 14:01 rem1776