FMS icon indicating copy to clipboard operation
FMS copied to clipboard

Makes MAX_FIELDS_PER_FILE a namelist variable and allocates

Open thomas-robinson opened this issue 3 years ago • 4 comments

Description Changes the max_fields_per_file to a namelist variable, and allocated the fields with this value.

Fixes #747

How Has This Been Tested? make run with intel

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] New check tests, if applicable, are included
  • [ ] make distcheck passes

thomas-robinson avatar May 20 '21 13:05 thomas-robinson

@menzel-gfdl can you test this? Does it fulfill your request?

thomas-robinson avatar May 20 '21 13:05 thomas-robinson

@menzel-gfdl do you still want this?

thomas-robinson avatar Jan 20 '22 14:01 thomas-robinson

@thomas-robinson sorry I've been distracted by a lot of other projects. What are your thoughts? I proposed this because we kind of need 5d diagnostics (time, z, lat, lon, spectral dimension). Right now our only option is to create one variable per spectral dimension (band, wavenumber, gpoint, etc.), which as you can imagine leads to a very high number of diagnostics. Is there a better solution?

menzel-gfdl avatar Jan 20 '22 15:01 menzel-gfdl

@menzel-gfdl Yes there is a plan to support more dimensions in the diag manager rewrite. Although the target is September, there is no guarantee that 5D support will be working by then. If this PR solves your problem more immediately, then why not take it now. I don't think there is a reason why this shouldn't be done.

thomas-robinson avatar Jan 20 '22 15:01 thomas-robinson