FMS icon indicating copy to clipboard operation
FMS copied to clipboard

test_horiz_interp: Don't over-allocate arrays

Open J-Lentz opened this issue 3 months ago • 0 comments

Description In the horiz_interp_type assignment 1x2d bicubic test, there are four allocatable arrays for which the number of elements allocated exceeds the number that get initialized:

  • lon_src_1d
  • lat_src_1d
  • lon_out_1d
  • lat_out_1d

This PR shortens the sizes of the arrays to match the number of elements that get initialized.

Fixes horiz_interp tests 23-24 with ifort using strict debug flags. It also fixes the tests with the Cray compiler. I'm requesting a careful review from @rem1776, because while this change does make the tests pass, I'm not sure whether or not the over-allocation may be a deliberate part of the test.

How Has This Been Tested? horiz_interp tests build, run, and pass with CCE 18 on C5 and with ifort using the following debug flags:

-check all -fpe0 -fp-stack-check -fstack-security-check -ftrapuv -init=arrays,minus_huge,snan

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] New check tests, if applicable, are included
  • [x] make distcheck passes

J-Lentz avatar Oct 28 '24 18:10 J-Lentz