FMS icon indicating copy to clipboard operation
FMS copied to clipboard

diag output yaml routine

Open rem1776 opened this issue 2 years ago • 4 comments

Description adds a routine to write a yaml with information on outputted files. Prints all possible fields for files and their variables, leaving them empty if no value was set. Prints during the fms_diag_object_end call. I also needed to add a trim to one of the calls in fms_diag_file_object, otherwise gcc would mess up the filename string and crash.

The time_utils changes were unrelated, i thought i had some issues with it but just needed a reconfigure. I left the changes in though since an intrinsic name being used for a variable can mess with some compilers.

How Has This Been Tested? intel, gcc on amd

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] New check tests, if applicable, are included
  • [ ] make distcheck passes

rem1776 avatar Nov 28 '22 17:11 rem1776

@rem1776 I'm looking through the PRs and found this one. Have you worked on it at all? It looks like there are some merge conflicts now also.

thomas-robinson avatar Apr 06 '23 13:04 thomas-robinson

@rem1776 I'm looking through the PRs and found this one. Have you worked on it at all? It looks like there are some merge conflicts now also.

Yeah this is basically finished up the main issue was with the intel CI, it seems to pass when I run it with anything even in the CI's docker image but for some reason fails on the github runner so its pretty hard to figure out what's wrong.

I'll update this and take another look, apparently theres a github action that'll let you ssh into the runner so I'll give that a shot (or maybe a new intel image will fix it).

rem1776 avatar Apr 06 '23 14:04 rem1776

@rem1776 did i drop the ball on this one? I thought something like this was already merged.

thomas-robinson avatar Sep 28 '23 12:09 thomas-robinson

@rem1776 did i drop the ball on this one? I thought something like this was already merged.

I think it had that intel ci issue that was impossible to debug so just got forgotten about, might be fixed now with updated ci.

rem1776 avatar Sep 28 '23 13:09 rem1776