FMS icon indicating copy to clipboard operation
FMS copied to clipboard

Remove retain_cm3_bug in interpolator

Open thomas-robinson opened this issue 1 year ago • 5 comments

Describe the bug The namelist variable retain_cm3_bug should be removed from FMS

To Reproduce retain_cm3_bug=.true. is set by default. Do we still want to keep this?

Expected behavior This should either be the default behavior and the namelist variable should be removed

System Environment

Additional context This is for the AM5 code prune clean up

thomas-robinson avatar Jul 12 '22 19:07 thomas-robinson

retain_cm3_bugs is set to .false. in the xmls (did not check all the xmls though) and is used/found in other model components listed below:

  • atmos_phys, particularly in atmos_shared/tracer_driver

  • mom6/coupled_AM2_LM3_SIS/CM2G63L/static_input.nml

  • mom6/coupled_AM2_LM3_SIS/CM2G63L/input.nml

I'll remove it and test it.

mlee03 avatar Aug 03 '22 18:08 mlee03

@mlee03 Have you made progress on this?

thomas-robinson avatar Aug 23 '22 13:08 thomas-robinson

@thomas-robinson, there's another variable in atmos_shared that is also called retain_cm3_bugs. Though the one in atmos_shared is part of a different nml, I assume they're correlated. I was planning on removing it from atmos_shared also and testing it before making the PR to FMS.

mlee03 avatar Aug 23 '22 13:08 mlee03

The project set for this is 2022.04, so this would need to be ready in about 2 weeks to make it in. Do you think that's possible? If so, I will leave it. If not, we can change it to a later release.

thomas-robinson avatar Aug 23 '22 13:08 thomas-robinson

@thomas-robinson I added this to the project a while ago, thought I had it removed. This'll go into the next one (2022.05), at least last I checked with @mlee03

rem1776 avatar Aug 23 '22 14:08 rem1776