Update make templates to guess HDF5 directories

[underwoo]

Added new configuration variables HDF5_LDFLAGS and HDF5_FLAGS to allow user to set location of HDF5 directories. Also added bits to have make guess location using the h5fc -show command.

Fixes #21

[underwoo]

I did. The problem with the MPI_FLAGS is that it was specific for mpich2. Any other MPI library could not be used. The way MPI should be handled is via the mpi compiler wrappers: mpicc, mpif90, etc.

-- Seth Underwood

S/W Development Process Lead Modeling Systems Group GFDL/NOAA/DOC 201 Forrestal Road Princeton, NJ 08540-6649

(609) 452-5847 Office (304) 376-9002 Cell (609) 987-5063 Fax [email protected]

On Mon, Dec 2, 2019 at 8:42 AM Tom Robinson [email protected] wrote:

@thomas-robinson requested changes on this pull request.

I also noticed this HDF5 issue and was working on something to fix it. This is much more elegant than my hack fix. I'm curious about the MPI changes. We can either update the commit message or include it the merge commit message.

In exec/templates/gnu.mk https://github.com/NOAA-GFDL/AM4/pull/22#discussion_r352599619:

@@ -96,9 +101,7 @@ else FPPFLAGS += $(NETCDF_FLAGS) endif

Fortran Compiler flags for the MPICH MPI library

-ifndef MPI_FLAGS -FPPFLAGS += $(shell pkg-config --cflags-only-I mpich2-c) -else +ifdef MPI_FLAGS

@underwoo https://github.com/underwoo did you intend to also change the MPI flags in the make templates? It's not mentioned in the commit message.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/AM4/pull/22?email_source=notifications&email_token=AADJUS4UACQBIXAJGV5JXJLQWUGEZA5CNFSM4JSLJ2XKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNRM5JQ#pullrequestreview-325242534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADJUS76YD7QQXOLXTSC3Z3QWUGEZANCNFSM4JSLJ2XA .

[underwoo]

@thomas-robinson this is still open, should it be or can it be closed?