Fixed excessive evaporation when both innerloop=T and mraerosol=T

[AnningCheng-NOAA]

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.) Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
When turning on Inner loop and setting mraerosol=T, too much evaporation from aerosol below the cloud layer causing global mean liquid water decreasing nearly 40 g/m^2. turning off evaporation from NWFA, but turning on the evaporation without aerosol influence. Is a change of answers expected from this PR?
Yes. new baselines for atmaero_control_p8_rad_micro_intel merra2_thompson_intel

Issue(s) addressed

https://github.com/ufs-community/ufs-weather-model/issues/2219

Link the issues to be closed with this PR, whether in this repository, or in another repository. (Remember, issues should always be created before starting work on a PR branch!)

• fixes #<issue_number>
• fixes noaa-emc/fv3atm/issues/<issue_number>
• fixed https://github.com/ufs-community/ufs-weather-model/issues/2219 https://github.com/ufs-community/ccpp-physics/pull/194

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

• Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
• Please commit the regression test log files in your ufs-weather-model branch regression tests are successful in hera and log file uploaded in https://github.com/ufs-community/ufs-weather-model/pull/2221

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first? If so add the "waiting for other repos" label and list the upstream PRs

• waiting on noaa-emc/nems/pull/<pr_number>
• waiting on noaa-emc/fv3atm/pull/<pr_number>
• waiting on https://github.com/ufs-community/ufs-weather-model/pull/2221

[grantfirl]

@AnningCheng-NOAA We'd like to combine this with a CCPP Framework commit hash update. I can walk you through this, or, if you add me as a collaborator with write permissions, I can do it for you and push to this branch. To add me as a collaborator, go to https://github.com/AnningCheng-NOAA/fv3atm/, click on Settings, then Collaborators. Click the "Add people" button and add the user 'grantfirl' as a collaborator.

[AnningCheng-NOAA]

@Grant Firl @.***> just added you as a collaborator. Please let me know if it works.

On Fri, Apr 19, 2024 at 11:51 AM Grant Firl @.***> wrote:

@AnningCheng-NOAA https://github.com/AnningCheng-NOAA We'd like to combine this with a CCPP Framework commit hash update. I can walk you through this, or, if you add me as a collaborator with write permissions, I can do it for you and push to this branch. To add me as a collaborator, go to https://github.com/AnningCheng-NOAA/fv3atm/, click on Settings, then Collaborators. Click the "Add people" button and add the user 'grantfirl' as a collaborator.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/fv3atm/pull/816#issuecomment-2066849169, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIMWEZSUVMTTIDQXOGLY6E4PJAVCNFSM6AAAAABFSAX7USVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWHA2DSMJWHE . You are receiving this because you were mentioned.Message ID: @.***>

[grantfirl]

@grant Firl @.> just added you as a collaborator. Please let me know if it works. … On Fri, Apr 19, 2024 at 11:51 AM Grant Firl @.> wrote: @AnningCheng-NOAA https://github.com/AnningCheng-NOAA We'd like to combine this with a CCPP Framework commit hash update. I can walk you through this, or, if you add me as a collaborator with write permissions, I can do it for you and push to this branch. To add me as a collaborator, go to https://github.com/AnningCheng-NOAA/fv3atm/, click on Settings, then Collaborators. Click the "Add people" button and add the user 'grantfirl' as a collaborator. — Reply to this email directly, view it on GitHub <#816 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIMWEZSUVMTTIDQXOGLY6E4PJAVCNFSM6AAAAABFSAX7USVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWHA2DSMJWHE . You are receiving this because you were mentioned.Message ID: @.***>

Yes, it worked fine. Thanks.

[grantfirl]

This PR is also waiting on https://github.com/NCAR/ccpp-framework/pull/556

[grantfirl]

Associated CCPP-framework PR is https://github.com/NCAR/ccpp-framework/pull/555

[grantfirl]

@BrianCurtis-NOAA The commit hash and the branch name in .gitmodules is correct for CCPP-framework in the FV3atm PR.

[AnningCheng-NOAA]

I have just added a line to mention that this PR has been combined with PR#555

On Tue, Apr 30, 2024 at 4:24 PM Grant Firl @.***> wrote:

@BrianCurtis-NOAA https://github.com/BrianCurtis-NOAA The commit hash and the branch name in .gitmodules is correct for CCPP-framework in the FV3atm PR.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/fv3atm/pull/816#issuecomment-2087102216, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIPBLCT4SXKFOM5TF3LY774W7AVCNFSM6AAAAABFSAX7USVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBXGEYDEMRRGY . You are receiving this because you were mentioned.Message ID: @.***>

[grantfirl]

@zach1221 CCPP PRs have been merged and this is updated and ready to approve/merge.

[zach1221]

ccpp-physics/frameworks PRs merged.

@zach1221 CCPP PRs have been merged and this is updated and ready to approve/merge.

Thanks, Grant! @jkbk2004 @BrianCurtis-NOAA this PR is ready for review