fv3atm icon indicating copy to clipboard operation
fv3atm copied to clipboard

Error checking in GFS_typedefs.F90 does not abort coupled model

Open pjpegion opened this issue 2 years ago • 0 comments

Description

The error checking logic in GFS_typedefs.F90 only uses a stop, which only aborts the atmospheric tasks, the ocean and ice model do not get an abort message and just hang.

To Reproduce:

hera / intel Give explicit steps to reproduce the behavior.

  1. run a coupled RT
  2. then change cplflx=.false.
  3. then, model write error message, and atmosphere model processor abort, but model just hangs

Additional context

It looks like GFS_typedefs.F90 should return an error code so atmos.F90 can execute the mpp_errr(FATAL,...) In general, I see other places where stop are used, and should be changed.

pjpegion avatar May 17 '22 18:05 pjpegion