nnpdf icon indicating copy to clipboard operation
nnpdf copied to clipboard

Unweighting implementation

Open toonhasenack opened this issue 1 year ago • 3 comments
trafficstars

Calculation of the unweighted weights in the vp framework. Module can be called with vp-unweight "path to chi2".csv "number of datapoints"

toonhasenack avatar May 16 '24 10:05 toonhasenack

Why is this a cli command and not just a vp action?

RoyStegeman avatar May 16 '24 12:05 RoyStegeman

@RoyStegeman, I followed the suggestion of @scarlehoff to do it this way.

toonhasenack avatar May 18 '24 11:05 toonhasenack

@toonhasenack Just to echo what has been above about the re/un-weighting being self-consistent. Everything except the generation of the theory predictions should be here, ie from the computations of the $\chi^2$ to the final dumping of the PDFs. Ideally, the theory predictions should also be stored in ../NNPDF/theories.

Also agreed on this being vp actions instead of scripts.

If you want, I could take over this PR from this point.

Radonirinaunimi avatar May 20 '24 21:05 Radonirinaunimi