Remove `--accept-arin-rpa` and `routinator-init` as they are no longer required

[AlexanderBand]

https://www.arin.net/announcements/20220926/

[ximon18]

Some things to do:

• [x] Remove support for --accept-arin-rpa in routinator init. N/A - routinator init no longer exists.
• [ ] Update the installation instructions, initialisation page, building page and manual page at RtD.
• [ ] Update the man page.
• [x] Update the README. N/A - it no longer contains detailed instructions but links to the docs._
• [x] Update the README at Docker Hub. Updated to match the GitHub README.
• [x] Pre-init Routinator inside the Docker image including all TALs? N/A - routinator init no longer exists.
• [x] Remove invocation of routinator init in GitHub Actions pkg workflow, specifically in pkg/test-scripts/test-routinator.sh.
• [x] Update the README at https://github.com/NLnetLabs/routinator/tree/main/tals

[AlexanderBand]

After installation with apt, immediately start running with the default settings en have systemd enable start at boot.

[ximon18]

Removing routinator-init and changing the systemd service to be enabled and to start automatically requires additional changes in the following places:

• [x] Remove the pkg/common/routinator-init script.
• [x] Cargo.toml should no longer bundle the routinator-init script for DEB and RPM packages.
• [ ] More updates to the installation and initialisation docs pages.
• [x] Remove the invocation of routinator-init entirely from pkg/test-scripts/test-routinator.sh and update it to verify that the service is started automatically, rather than starting it via systemctl start.
• [x] Change enable = false to enable = true in systemd-units in Cargo.toml.
• [x] Remove pkg/common/service.preset and the references to it in Cargo.toml?
• [x] Change the systemctl invocations in pkg/rpm/scriptlets.toml.
• [x] On upgrade remove any existing routinator-init script.

[ximon18]

Should we leave routinator-init but replace it by a dummy This command no longer needs to be run warning or similar for one release?

[ximon18]

For upgrade of an existing deployment, maybe the systemd service shouldn't be started if it isn't already running?

[AlexanderBand]

We can also take out the init --help, alleviating the issue described in #583.

[ximon18]

@AlexanderBand: Surely not the entirety of it as routinator init will still exist, e.g. to list TALs and choose to do custom TAL setups etc?

[partim]

So, the proposed plan for this is: Get rid of installing TAL files entirely.

By default, Routinator will use the five RIR TALs that are baked into the binary. If you want to install your own TAL files, you need to explicitly specify a --tal-dir and Routinator will use the files in that directory in addition to the built-in TALs. If you don’t want the built-in TALs, you can say so via a new --no-rir-tals options.

How does that sound?

[ximon18]

Should we leave routinator-init but replace it by a dummy This command no longer needs to be run warning or similar for one release?

We discussed this and concluded that the script would be removed entirely.

[ximon18]

For upgrade of an existing deployment, maybe the systemd service shouldn't be started if it isn't already running?

The implementation starts the service on the basis that normal usage previously would be to do init then start the service and if the user hadn't done that already they still would have intended to do so, and normal behaviour now on initial install is to start so this makes the upgrade and initial install behaviour the same.