NLnetLabs
Updates to ldns_is_rrset()
This PR proposes two updates to ldns_is_rrset():
- to take into account TTL --> see RFC2181, Section 5.2 and RFC9499, Section 5
- do case insensitive comparison of owner names, using function
ldns_dname_compare()--> I couldn't find a proper reference from the same RFCs regarding RRsets specifically, but from a practical point on view it seems appropriate. Also see RFC4343.
PS: I couldn't find any unitary test for this method in the test directory, so this PR is untested at the moment. Please feel free to provide additional changes in that regard.
@wtoorop have you had time to review this PR? what do you think of this proposal?
Okay @tgreenx , I reviewed, and I really like the case insensitive dname compare. I'm a bit less enthusiastic about making equal TTLs a requirement, because that would be a backwards compatibility breaking change. Maybe we could introduce a new function bool ldns_is_rrset_strict(const ldns_rr_list *rr_list) that also takes along the TTL? WDYT?
Okay @tgreenx , I reviewed, and I really like the case insensitive dname compare. I'm a bit less enthusiastic about making equal TTLs a requirement, because that would be a backwards compatibility breaking change. Maybe we could introduce a new function
bool ldns_is_rrset_strict(const ldns_rr_list *rr_list)that also takes along the TTL? WDYT?
Hi Willem, thanks for the review. Sure we can do that, I've just pushed commit https://github.com/NLnetLabs/ldns/pull/251/commits/0fd9031e2e34f291de0687739acf23469d4744a9 in that regard. I was not sure if I needed to update any doc/ file, please tell me if that is required.