papercolor-theme icon indicating copy to clipboard operation
papercolor-theme copied to clipboard

FloatBorder and NormalFloat background for lsp_signature #enhancement

Open alexeygumirov opened this issue 2 years ago • 3 comments

NeoVIM 0.8

I use ray-x/lsp_signature.nvim plugin for function definitions popups in the floating windows. Additional parameters are required (as described in the relevant issue here: https://github.com/ray-x/lsp_signature.nvim/issues/193), because without them floating border looks like this:

wrong_border

Borders for this are having default NeoVIM colors because they require following highlight to setup:

  " Neovim (LSP) diagnostics
  if has('nvim')
   ...
    exec 'hi FloatBorder' . s:bg_background
    exec 'hi NormalFloat' . s:bg_background

After this fix borders look correct: correct border

alexeygumirov avatar Oct 09 '22 21:10 alexeygumirov

Can you make a PR for this, please?

NLKNguyen avatar Oct 11 '22 21:10 NLKNguyen

@NLKNguyen This seems to be a general issue: https://github.com/NLKNguyen/papercolor-theme/issues/195

I could make a PR for this specific issue (https://github.com/NLKNguyen/papercolor-theme/commit/18c9cbd303ec5a070127255eebbcda796649cf94), but split panes are broken, too. Are you able to look into this?

binarious avatar Jun 27 '23 06:06 binarious

Can someone check to see if this is still an issue with Neovim 0.10?

sjshuck avatar May 24 '24 03:05 sjshuck