Ronald Portier

Results 154 comments of Ronald Portier

@ddejong-therp pre-commit created setup files. Those must be git added and included in the PR. See details of pre-commit check. You might want to squash your commits.

Please add some unit test to get this green. Suggestion: - Create journals of different types in the test setup, and set three of them up as company defaults; -...

@rafaelbn Preventing the use of old journals was just an example of what the module can achieve. The basics is that the users get to control what journal is picked...

I had to make one correction in another module as this had a problem in the login template that was inherited in the enter sms code template: https://github.com/OCA/server-auth/pull/724/files#diff-564288b4f2312458e84b608a19806e84706dcd2f700bc83bf4b3763b68881786

@StefanRijnhart Could you have a look at this one and reopen it? Maybe even review and merge it?