PiZilla icon indicating copy to clipboard operation
PiZilla copied to clipboard

Browser based notifications

Open nkprince007 opened this issue 7 years ago • 5 comments

Show browser based notifications on completion of file upload.

nkprince007 avatar Oct 15 '17 14:10 nkprince007

https://github.com/georgeosddev/react-web-notification seems to be a great place to start with, especially since it's react again.

kudos++, if you could do this without adding a new dependency.

nkprince007 avatar Oct 15 '17 14:10 nkprince007

@nkprince007 can you tell me which file deals with file upload?

pranay414 avatar Dec 06 '17 06:12 pranay414

The backend is handled here: https://github.com/NITDgpOS/PiZilla/blob/master/server/routes.js#L16-L42

Once the upload has finished, this is where you can ask the client to push the notification.

nkprince007 avatar Dec 06 '17 12:12 nkprince007

Actually, it's better and easier to use the HTML5 Notifications API directly. Refer MDN Docs on how to use it here.

nkprince007 avatar Dec 06 '17 12:12 nkprince007

@nkprince007 please review my PR

pranay414 avatar Dec 21 '17 21:12 pranay414