Nic Lin comments

Results 12 comments of


                                            Nic Lin

Caller check in `execute_on_plugin`

Thanks for the info! TIL `@view` does not enforce non state mutability... :+1: on rename or updating the doc. It would be helpful IMO.

Check assembly blocks for unsafe operations

Hi, is there any update on this? The current validation still does not catch these unsafe operations in assembly. ZkSync has this [`delegateAdditional` function](https://github.com/matter-labs/zksync/blob/82cfd3ff19d3bfa071c0a5061390b8f3d91f47ee/contracts/contracts/ZkSync.sol#L1033) which would not be caught by...

Try foundry fmt

`prettier` will convert into multiline if number of function param exceed three, even if line length hasn't reach 160 limit.

veLON contract with early withdrawal penalty

It would be great if commit 33261c3 can be split into two: first copy ve.sol and second apply changes on top. Then we can review second commit and see the...

Fix v6.0.1

> fix handling logic for makerToken as ETH in RFQ contract This does not feel like a "fix". This is changing how we treat WETH as maker token: - before...

Fix v6.0.1

Please add a readme or a natspec/comment for how we handle different maker tokens, to help others better understand how it works. ``` In RFQ, - if maker token is...

[hardhat-foundry] Add support for configuring path to foundry.toml

Thanks for taking a look at it!

Minor updates

Not an important update. Leave it for now. Will come back to fix the CI errors.

`AddPeer` fails when `go test`: dial attempt failed, context deadline exceeded

@mhchia Occasionally, still not sure why.

Connection(peer) management for the underlying overlay

Hi @raulk thanks for the great introduction on connection manager. I'm currently looking into it, play around and have a few questions regarding trimming connection: 1. `cm.peers`(or `cm.connCount`) is only...