uni icon indicating copy to clipboard operation
uni copied to clipboard

Feature/create reservations

Open jlcrodrigues opened this issue 2 years ago • 3 comments

Closes #657 Depends on #795

Added the ability to reserve library rooms from the reservations tab.

The website works especially slow for this service.

Also, there are a lot of errors that can occur for a reservation (e.g. library closed) so take this in mind to test.

Review checklist

  • [x] Terms and conditions reflect the current change
  • [ ] Contains enough appropriate tests
  • [x] If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • [x] Properly adds an entry in changelog.md with the change
  • [x] If PR includes UI updates/additions, its description has screenshots
  • [x] Behavior Is as expected
  • [x] Clean, well-structured code

jlcrodrigues avatar Oct 04 '23 14:10 jlcrodrigues

In the meeting, it was discussed that instead of the Circular Indicator, the reservation should do an optimistic update. However, because the room number is only known after the request is complete, I tried adding a shimmer effect. Please let me know what you think.

jlcrodrigues avatar Jan 11 '24 22:01 jlcrodrigues

In the meeting, it was discussed that instead of the Circular Indicator, the reservation should do an optimistic update. However, because the room number is only known after the request is complete, I tried adding a shimmer effect. Please let me know what you think.

I like it, but I'll discuss it with the team nevertheless

bdmendes avatar Jan 12 '24 13:01 bdmendes

Codecov Report

Attention: Patch coverage is 5.09091% with 522 lines in your changes missing coverage. Please review.

Project coverage is 16%. Comparing base (9bbf5d4) to head (3015163). Report is 2178 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #998    +/-   ##
=======================================
- Coverage       17%    16%    -0%     
=======================================
  Files          207    217    +10     
  Lines         6418   6903   +485     
=======================================
+ Hits          1037   1067    +30     
- Misses        5381   5836   +455     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jan 24 '24 22:01 codecov[bot]

Thanks for your work here. This got a little deprecated with all the updates we made to the app. I'm closing this PR but this logic will be useful in the future, if we want to add this feature.

DGoiana avatar May 20 '25 15:05 DGoiana