uni icon indicating copy to clipboard operation
uni copied to clipboard

Redesign/translations

Open Adriano-7 opened this issue 11 months ago • 3 comments

Closes #1461

Some notes:

  • This PR fixes the translation of courses and course_units
  • The calendar and the schedule links break when the page is /en, that's why i use the languageSensitive condition
  • The course unit sheet is still in portuguese eventhough the link is /en because the link we're using returns the info in portuguese
  • There's a problem with the abbreviation of finished courses (see the TODO). LEIC it appears as BICE

Review checklist

  • [ ] Terms and conditions reflect the current change
  • [ ] Contains enough appropriate tests
  • [ ] If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • [ ] Properly adds an entry in changelog.md with the change
  • [ ] If PR includes UI updates/additions, its description has screenshots
  • [ ] Behavior is as expected
  • [ ] Clean, well-structured code

Adriano-7 avatar Feb 19 '25 14:02 Adriano-7

The "BEIC" problem is not from here, should we fix it here? I don't think the goal now, we can live with that and fix later, my opinion

thePeras avatar Mar 18 '25 23:03 thePeras

The BEIC problem happens because the way we're getting the accronym is through regex. I don't personally think is a big deal, the way to solve this would be through an api or somehow changing the fetcher to give us that info

Adriano-7 avatar Mar 23 '25 22:03 Adriano-7

hould we fix it here? I don't think the goal now, we can live with that and fix later, my opinion

Exactly, the fix seems complex, so ignore it that for now

thePeras avatar Mar 24 '25 16:03 thePeras

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60%. Comparing base (b826e54) to head (fd96a49). :warning: Report is 1 commits behind head on develop.

:x: Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1482   +/-   ##
=======================================
  Coverage       60%     60%           
=======================================
  Files            2       2           
  Lines           81      81           
=======================================
  Hits            48      48           
  Misses          33      33           
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 04 '25 17:08 codecov[bot]