fix: no exams in mobility
This PR makes it so uni doesn't try to fetch exams for students with the mobility course or other courses with a null id.
Review checklist
- [x] Terms and conditions reflect the current change
- [ ] Contains enough appropriate tests
- [x] If aimed at production, writes a new summary in
whatsnew/whatsnew-pt-PT - [x] Properly adds an entry in
changelog.mdwith the change - [x] If PR includes UI updates/additions, its description has screenshots
- [x] Behavior is as expected
- [x] Clean, well-structured code
Codecov Report
:x: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 12%. Comparing base (b330fc3) to head (4d0205b).
:warning: Report is 1373 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #1402 +/- ##
=======================================
- Coverage 12% 12% -0%
=======================================
Files 266 266
Lines 7218 7240 +22
=======================================
Hits 806 806
- Misses 6412 6434 +22
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
I can't test this because I don't have a mobility account. Even then, it's likely that it might not fix the issue.
I can't test this because I don't have a mobility account. Even then, it's likely that it might not fix the issue.
I think the issue is more complicated than this. Did you check the student account I leave at #uni-reports?
I can't test this because I don't have a mobility account. Even then, it's likely that it might not fix the issue.
I think the issue is more complicated than this. Did you check the student account I leave at #uni-reports?
Nop, I'll check it out now
The solution I propose: If mobility course is identified, get exams method maps every enrollment and gets is exams by using the same method of ge course exams because the html page is exactly the same.
Closed due to inactivity. However, we must see this in the future again.
To be honest, it did fix half the problem (course units). The other problem was exams.
Could you explain what was the problem with the course units please?
International students are enrolled in a "Mobilidade" course in SIGARRA. In that course, they have different course units from different courses from FEUP.
However, "Mobilidade" is not a course that exists in SIGARRA normally, it's a special course and it's ID is null. Because of that, the fetcher throws an exception when parsing that course and, because of that, no course units are fetched from SIGARRA.