uni icon indicating copy to clipboard operation
uni copied to clipboard

removed profile pic and added an horizontal line to some pages

Open clarapbsousa opened this issue 1 year ago • 2 comments

Closes #1268 The rightButton has been removed from home.dart, general.dart, and secondary.dart. Additionally, top_navigation_bar.dart has been updated to include an optional horizontal line below the title for pages titled "Faculty" or "Restaurants".

Review checklist

  • [ ] Terms and conditions reflect the current change
  • [ ] Contains enough appropriate tests
  • [ ] If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • [ ] Properly adds an entry in changelog.md with the change
  • [x] If PR includes UI updates/additions, its description has screenshots
  • [ ] Behavior is as expected
  • [ ] Clean, well-structured code

Imagem de 07-08-24 à(s) 12 06 Imagem de 07-08-24 à(s) 12 05 Imagem de 07-08-24 à(s) 12 05 (1)

clarapbsousa avatar Aug 07 '24 11:08 clarapbsousa

Codecov Report

Attention: Patch coverage is 33.33333% with 32 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (0d8b0af) to head (5efe46e). Report is 508 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1294   +/-   ##
===========================================
+ Coverage           12%     12%   +1%     
===========================================
  Files              266     264    -2     
  Lines             7201    7208    +7     
===========================================
+ Hits               806     808    +2     
- Misses            6395    6400    +5     

codecov[bot] avatar Aug 14 '24 11:08 codecov[bot]

Looks good! To finalize, can we just give a little bit of opacity to the line, I think it is too dark.

DGoiana avatar Aug 20 '24 12:08 DGoiana

@clarapbsousa can you attach the final screenshots of the result?

DGoiana avatar Oct 16 '24 22:10 DGoiana