ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

fix(module:color-picker): avoid emitted twice nzOnChange event

Open Nicoss54 opened this issue 9 months ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When we change the color of color-picket nzOnChange event is emitted twice

Issue Number: #8502

What is the new behavior?

When we change the color of color picker nzOnChange event is emitted only one time

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Nicoss54 avatar May 02 '24 22:05 Nicoss54

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar May 02 '24 22:05 zorro-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.58%. Comparing base (81ef077) to head (08295d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8530   +/-   ##
=======================================
  Coverage   91.57%   91.58%           
=======================================
  Files         533      533           
  Lines       18336    18338    +2     
  Branches     2801     2801           
=======================================
+ Hits        16792    16794    +2     
  Misses       1226     1226           
  Partials      318      318           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 02 '24 23:05 codecov[bot]

LGTM

OriginRing avatar May 10 '24 03:05 OriginRing