ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

fix(module:card): use skeleton instead to card-loading-content

Open HyperLife1119 opened this issue 9 months ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #8518

image

What is the new behavior?

In the latest antd 4, card-loading-content no longer exists and is replaced by the skeleton.

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

HyperLife1119 avatar Apr 30 '24 03:04 HyperLife1119

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.57%. Comparing base (81ef077) to head (033a43c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8528      +/-   ##
==========================================
- Coverage   91.57%   91.57%   -0.01%     
==========================================
  Files         533      532       -1     
  Lines       18336    18333       -3     
  Branches     2801     2801              
==========================================
- Hits        16792    16789       -3     
  Misses       1226     1226              
  Partials      318      318              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 30 '24 04:04 codecov[bot]