ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

refactor: removed all usages of <color-sketch>

Open ParsaArvanehPA opened this issue 11 months ago • 6 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently there are 2 usages of an external library called color-sketch in our codebase; one in the Watermark component, and another one in the footer of the doucment site.

What is the new behavior?

Removed all usages of color-sketch and use Ng-zorro's built-in color picker.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Usages:

image

ParsaArvanehPA avatar Mar 25 '24 05:03 ParsaArvanehPA

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Mar 25 '24 05:03 zorro-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.57%. Comparing base (81ef077) to head (b0d78d6). Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8465      +/-   ##
==========================================
- Coverage   91.57%   91.57%   -0.01%     
==========================================
  Files         533      532       -1     
  Lines       18336    18334       -2     
  Branches     2801     2801              
==========================================
- Hits        16792    16789       -3     
- Misses       1226     1227       +1     
  Partials      318      318              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 25 '24 05:03 codecov[bot]

Hi @ParsaArvanehPA , thanks to your nice contribution, I left some suggesions to remove useless styles and I hope this message finds you well :)

Laffery avatar Apr 19 '24 01:04 Laffery

Hi @ParsaArvanehPA , thanks to your nice contribution, I left some suggesions to remove useless styles and I hope this message finds you well :)

Hi @Laffery , thank you for checking my PR. I think you forgot to submit your reviews because I don't see any requested changes.

ParsaArvanehPA avatar Apr 21 '24 12:04 ParsaArvanehPA

Hi @Laffery , thank you for checking my PR. I think you forgot to submit your reviews because I don't see any requested changes.

@ParsaArvanehPA I'm sorry about that, it's available now

Laffery avatar Apr 29 '24 09:04 Laffery

Hi @Laffery , thank you for checking my PR. I think you forgot to submit your reviews because I don't see any requested changes.

@ParsaArvanehPA I'm sorry about that, it's available now

Changes have been made, thanks again for checking it out @Laffery

ParsaArvanehPA avatar May 12 '24 07:05 ParsaArvanehPA