ng-zorro-antd
ng-zorro-antd copied to clipboard
feat(module:menu): add click trigger for submenus
PR Checklist
Please check if your PR fulfills the following requirements:
- [✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
- [✔] Tests for the changes have been added (for bug fixes / features)
- [✔] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:
What is the current behavior?
In Ant design, it is possible to choose between a click
or a hover
trigger for submenues.
Issue Number: #4745
What is the new behavior?
click
trigger implemented.
Does this PR introduce a breaking change?
[ ] Yes
[✔] No
Other information
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.53%. Comparing base (
0a4f12c
) to head (8522b61
).
Additional details and impacted files
@@ Coverage Diff @@
## master #8461 +/- ##
==========================================
- Coverage 91.54% 91.53% -0.01%
==========================================
Files 536 536
Lines 18443 18447 +4
Branches 2907 2907
==========================================
+ Hits 16883 16885 +2
- Misses 1241 1242 +1
- Partials 319 320 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
partially approved
your requested changes are made, could you please check it once more
Hey guys I have some old branches that I want to take care of. Could you please review this again? @Laffery @HyperLife1119 @Nicoss54