ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

feat(module:table): radio selection type

Open ParsaArvanehPA opened this issue 11 months ago • 4 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [✔] Tests for the changes have been added (for bug fixes / features)
  • [✔] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In Ant design it is possible to have both checkbox and radio as selection type for columns; meanwhile we only support checkbox selection type.

Issue Number: #8029

What is the new behavior?

Now supports radio selection type.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

ParsaArvanehPA avatar Mar 20 '24 23:03 ParsaArvanehPA

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Mar 20 '24 23:03 zorro-bot[bot]

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.52%. Comparing base (0a4f12c) to head (105ad16).

Files Patch % Lines
components/table/src/cell/td-addon.component.ts 60.00% 1 Missing and 1 partial :warning:
components/table/src/addon/selection.component.ts 0.00% 1 Missing :warning:
...omponents/table/src/cell/th-selection.component.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8456      +/-   ##
==========================================
- Coverage   91.54%   91.52%   -0.02%     
==========================================
  Files         536      536              
  Lines       18443    18449       +6     
  Branches     2907     2908       +1     
==========================================
+ Hits        16883    16885       +2     
- Misses       1241     1244       +3     
- Partials      319      320       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 20 '24 23:03 codecov[bot]

Your requested changes are made, could you please check it again? @Laffery

ParsaArvanehPA avatar Jul 17 '24 10:07 ParsaArvanehPA

@Laffery Don't know why if failed the second time i pushed last time :) now is fixed 🙃

ParsaArvanehPA avatar Aug 04 '24 10:08 ParsaArvanehPA