ng-zorro-antd
ng-zorro-antd copied to clipboard
feat(module:table): radio selection type
PR Checklist
Please check if your PR fulfills the following requirements:
- [✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
- [✔] Tests for the changes have been added (for bug fixes / features)
- [✔] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:
What is the current behavior?
In Ant design it is possible to have both checkbox
and radio
as selection type for columns; meanwhile we only support checkbox
selection type.
Issue Number: #8029
What is the new behavior?
Now supports radio selection type.
Does this PR introduce a breaking change?
[ ] Yes
[✔] No
Other information
This preview will be available after the AzureCI is passed.
Codecov Report
Attention: Patch coverage is 42.85714%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 91.52%. Comparing base (
0a4f12c
) to head (105ad16
).
Additional details and impacted files
@@ Coverage Diff @@
## master #8456 +/- ##
==========================================
- Coverage 91.54% 91.52% -0.02%
==========================================
Files 536 536
Lines 18443 18449 +6
Branches 2907 2908 +1
==========================================
+ Hits 16883 16885 +2
- Misses 1241 1244 +3
- Partials 319 320 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Your requested changes are made, could you please check it again? @Laffery
@Laffery Don't know why if failed the second time i pushed last time :) now is fixed 🙃