ng-zorro-antd
ng-zorro-antd copied to clipboard
feat(module:typography): more edit triggers
PR Checklist
Please check if your PR fulfills the following requirements:
- [✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
- [✔] Tests for the changes have been added (for bug fixes / features)
- [✔] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:
What is the current behavior?
Currently editable texts in the Typography section only support edit icon as their trigger, as Ant design's triggers include icon, text and both.
What is the new behavior?
Described above.
Does this PR introduce a breaking change?
[ ] Yes
[✔] No
Other information
This preview will be available after the AzureCI is passed.
Make the test pass :)
Hi @Nicoss54 Sorry for the long delay, I will get back to you as soon as possible
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.50%. Comparing base (
13e8a45
) to head (816c62b
).
Additional details and impacted files
@@ Coverage Diff @@
## master #8420 +/- ##
==========================================
- Coverage 91.50% 91.50% -0.01%
==========================================
Files 534 534
Lines 18408 18414 +6
Branches 2904 2905 +1
==========================================
+ Hits 16844 16849 +5
Misses 1243 1243
- Partials 321 322 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.