ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

fix(module:carousel): not adapting to new size when resizing

Open ParsaArvanehPA opened this issue 1 year ago • 4 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [] Tests for the changes have been added (for bug fixes / features)
  • [] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[✔] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Carousel component currently does not adapt to the new size when it is resized.

Issue Number: #8359

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

I have set a 100ms delay for the the debounceTime, so the this.layout() method does not fire so often; but I am not sure as to what is the best value for dueTime of debounceTime.

ParsaArvanehPA avatar Jan 28 '24 08:01 ParsaArvanehPA

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Jan 28 '24 08:01 zorro-bot[bot]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6024bcc) 91.74% compared to head (6231f04) 91.75%. Report is 21 commits behind head on master.

Files Patch % Lines
components/carousel/carousel.component.ts 50.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8374      +/-   ##
==========================================
+ Coverage   91.74%   91.75%   +0.01%     
==========================================
  Files         520      519       -1     
  Lines       18019    18030      +11     
  Branches     2838     2838              
==========================================
+ Hits        16531    16543      +12     
  Misses       1185     1185              
+ Partials      303      302       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 28 '24 08:01 codecov[bot]

Please could you provide test for the code you added ?

Sure, I will get back to you with that as soon as I can.

ParsaArvanehPA avatar Jan 29 '24 19:01 ParsaArvanehPA

Please could you provide test for the code you added ?

Sorry for the delay; tests for the changes have been added. Thank you for reviewing my PRs @Nicoss54

ParsaArvanehPA avatar Feb 13 '24 14:02 ParsaArvanehPA