ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

fix(module:tabs): slide indicator missing in small screens

Open ParsaArvanehPA opened this issue 1 year ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [] Tests for the changes have been added (for bug fixes / features)
  • [] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[✔] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Slide indicator shrinks when the inline size of tab component is decreased.

Issue Number: #8351, #8384

What is the new behavior?

The mentioned problem is fixed.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

This line of code was originally added in this commit; currently Ant design no longer has these lines in it's code base, and by removing them the mentioned issue is fixed and no visual difference is made to other sections of Tabs component.

ParsaArvanehPA avatar Jan 27 '24 08:01 ParsaArvanehPA

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Jan 27 '24 08:01 zorro-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6024bcc) 91.74% compared to head (6326c33) 91.74%. Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8372   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         520      520           
  Lines       18019    18019           
  Branches     2838     2838           
=======================================
+ Hits        16531    16532    +1     
+ Misses       1185     1184    -1     
  Partials      303      303           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 27 '24 08:01 codecov[bot]