ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

fix(module: select): issue with nzScrollToBottom while display scaling

Open ajinkya2020 opened this issue 1 year ago • 4 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

On nz-select component nzScrollToBottom not getting triggered when display scaling is changed to 90% or 110%.

What is the new behavior?

Triggers nzScrollToBottom when user scrolls to the bottom with any display scale.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

ajinkya2020 avatar Jan 13 '24 19:01 ajinkya2020

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Jan 13 '24 19:01 zorro-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6024bcc) 91.74% compared to head (46d8f24) 91.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8355   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         520      520           
  Lines       18019    18019           
  Branches     2838     2838           
=======================================
+ Hits        16531    16532    +1     
+ Misses       1185     1184    -1     
  Partials      303      303           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 13 '24 19:01 codecov[bot]

LGTM

Nicoss54 avatar Jan 17 '24 08:01 Nicoss54

Hello @Nicoss54, when can we get this merged?

ajinkya2020 avatar Jan 30 '24 08:01 ajinkya2020

Any update on this?

ajinkya2020 avatar Mar 04 '24 18:03 ajinkya2020