ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

feat(module:spin): now supports fullscreen

Open ParsaArvanehPA opened this issue 1 year ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The spin component in our current version does not have the fullscreen mode feature that antd provides.

Issue Number: N/A

What is the new behavior?

The spin component has a new input property called nzFullscreen, which enables the display of a backdrop with the spin component when set to true.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

ParsaArvanehPA avatar Nov 24 '23 13:11 ParsaArvanehPA

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.72%. Comparing base (43b34ae) to head (66afc3c). Report is 178 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8183      +/-   ##
==========================================
+ Coverage   91.70%   91.72%   +0.01%     
==========================================
  Files         519      519              
  Lines       17885    17888       +3     
  Branches     2747     2836      +89     
==========================================
+ Hits        16401    16407       +6     
+ Misses       1182     1180       -2     
+ Partials      302      301       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 24 '23 13:11 codecov[bot]

This feature involves several design tokens, and we may need more work to support it. These design tokens may also affect our style synchronization work. https://github.com/ant-design/ant-design/blob/03409af97f8fa8b32acad7a388eb3fd8640c7c35/components/spin/style/index.ts#L67-L92

WDYT? @simplejason @OriginRing

HyperLife1119 avatar Nov 25 '23 16:11 HyperLife1119

This feature involves several design tokens, and we may need more work to support it. These design tokens may also affect our style synchronization work. https://github.com/ant-design/ant-design/blob/03409af97f8fa8b32acad7a388eb3fd8640c7c35/components/spin/style/index.ts#L67-L92

WDYT? @simplejason @OriginRing

I am not clear about what you mean by design tokens. Do you mean the style changes that make the spin component white? How does this affect the feature and the style synchronization work? Can we use the current design tokens until we support the new ones?

ParsaArvanehPA avatar Nov 27 '23 21:11 ParsaArvanehPA