ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

feat(module:image): zoom using mouse wheel

Open ParsaArvanehPA opened this issue 1 year ago • 6 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [✔] Tests for the changes have been added (for bug fixes / features)
  • [] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The image component in antd supports zooming in the image with the mouse wheel, but this feature is not available in our image component.

Issue Number: N/A

What is the new behavior?

The image can be zoomed in with the mouse wheel, and the zooming center is aligned with the mouse cursor position.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

ParsaArvanehPA avatar Nov 21 '23 17:11 ParsaArvanehPA

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Nov 21 '23 17:11 zorro-bot[bot]

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e856515) 91.75% compared to head (ac27383) 91.62%.

Files Patch % Lines
components/image/image-preview.component.ts 67.44% 14 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8180      +/-   ##
==========================================
- Coverage   91.75%   91.62%   -0.14%     
==========================================
  Files         519      519              
  Lines       18041    18076      +35     
  Branches     2842     2848       +6     
==========================================
+ Hits        16554    16562       +8     
- Misses       1184     1216      +32     
+ Partials      303      298       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 21 '23 17:11 codecov[bot]

@HyperLife1119 @Nicoss54 I would be grateful if you could review my pull request.

ParsaArvanehPA avatar Dec 07 '23 16:12 ParsaArvanehPA

@HyperLife1119 @Nicoss54 I would be grateful if you could review my pull request.

@HyperLife1119 i am going to tackle this if you’re ok ?

Nicoss54 avatar Dec 07 '23 16:12 Nicoss54

@HyperLife1119 @Nicoss54 I would be grateful if you could review my pull request.

@HyperLife1119 i am going to tackle this if you’re ok ?

Give it to you :)

HyperLife1119 avatar Dec 07 '23 16:12 HyperLife1119

LGTM

Nicoss54 avatar Dec 07 '23 18:12 Nicoss54