ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

feat(module:image): now supports horizontal and vertical flip

Open ParsaArvanehPA opened this issue 1 year ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [✔] Tests for the changes have been added (for bug fixes / features)
  • [✔] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The image component in our current version does not support horizontal and vertical flipping of the image, unlike the antd image component.

What is the new behavior?

The feature of flipping the image horizontally or vertically has been implemented.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

ParsaArvanehPA avatar Nov 17 '23 20:11 ParsaArvanehPA

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Nov 17 '23 20:11 zorro-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (23ae744) 91.75% compared to head (ffe3766) 91.75%. Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8168      +/-   ##
==========================================
- Coverage   91.75%   91.75%   -0.01%     
==========================================
  Files         519      519              
  Lines       18026    18041      +15     
  Branches     2838     2842       +4     
==========================================
+ Hits        16540    16553      +13     
- Misses       1184     1185       +1     
- Partials      302      303       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 17 '23 21:11 codecov[bot]

@HyperLife1119 I would be grateful if you could review my pull request.

ParsaArvanehPA avatar Nov 27 '23 22:11 ParsaArvanehPA

Can you resolve the conflict? I will merge it.

HyperLife1119 avatar Feb 19 '24 06:02 HyperLife1119

Can you resolve the conflict? I will merge it.

Yeah sure, Thanks @HyperLife1119.

I have 2 more branches that have conflicts and have PR: reviewed-approved tag that haven't been merged; should I notify you after I resolve those two branches too?

ParsaArvanehPA avatar Feb 19 '24 06:02 ParsaArvanehPA

Absolutely okay! @ParsaArvanehPA

HyperLife1119 avatar Feb 19 '24 06:02 HyperLife1119

Thank you for checking this pr @HyperLife1119

https://github.com/NG-ZORRO/ng-zorro-antd/pull/8180 https://github.com/NG-ZORRO/ng-zorro-antd/pull/8283

These are the two branches with conflicts I mentioned earlier, thanks in advance.

ParsaArvanehPA avatar Feb 19 '24 09:02 ParsaArvanehPA