ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

fix(module:upload): remove inline style to resolve CSP issue

Open arturovt opened this issue 1 year ago • 2 comments

This commit addresses the CSP issue by removing the inline style property from the input element within the nz-upload component. The use of inline style attributes necessitates the inclusion of unsafe-inline.

arturovt avatar Aug 23 '23 11:08 arturovt

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Aug 23 '23 11:08 zorro-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.62%. Comparing base (3dc1579) to head (6864915). Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8064      +/-   ##
==========================================
- Coverage   91.74%   91.62%   -0.13%     
==========================================
  Files         520      530      +10     
  Lines       18023    18391     +368     
  Branches     2838     2815      -23     
==========================================
+ Hits        16536    16851     +315     
- Misses       1184     1224      +40     
- Partials      303      316      +13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 04 '23 20:11 codecov[bot]

We should not add the new style directly to the antd style file, as this will interfere with the component style synchronization. We can either add the style to patch.less or use the style binding [style.display]="'none'".

HyperLife1119 avatar Mar 11 '24 07:03 HyperLife1119

We should not add the new style directly to the antd style file, as this will interfere with the component style synchronization. We can either add the style to patch.less or use the style binding [style.display]="'none'".

Updated.

arturovt avatar Mar 14 '24 12:03 arturovt