ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

fix #fff border in text button when apply ghost mode

Open bahram-azimbeyk opened this issue 1 year ago • 4 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

For this code: image

Before: image

After: image

image

bahram-azimbeyk avatar Jul 18 '23 09:07 bahram-azimbeyk

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Jul 18 '23 09:07 zorro-bot[bot]

Codecov Report

Merging #8021 (41800a5) into master (078aaf9) will increase coverage by 0.02%. The diff coverage is n/a.

:exclamation: Current head 41800a5 differs from pull request most recent head 5fa5273. Consider uploading reports for the commit 5fa5273 to get more accurate results

@@            Coverage Diff             @@
##           master    #8021      +/-   ##
==========================================
+ Coverage   91.65%   91.67%   +0.02%     
==========================================
  Files         515      515              
  Lines       17641    17641              
  Branches     2790     2790              
==========================================
+ Hits        16168    16172       +4     
+ Misses       1175     1169       -6     
- Partials      298      300       +2     

see 1 file with indirect coverage changes

codecov[bot] avatar Jul 18 '23 10:07 codecov[bot]

Good first issue! Should be consistent with ant design, there is a border when hovering on the button.

image

Laffery avatar Nov 17 '23 07:11 Laffery

@bahram-azimbeyk changes are not made yet, could you apply the requested change please ? :)

Nicoss54 avatar Dec 11 '23 16:12 Nicoss54