ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

fix(module:testing): update ComponentBed interface

Open drackp2m opened this issue 2 years ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

tests pass without errors Error: components/core/testing/component-bed.ts:38:5 - error TS2322: Type 'TestBed' is not assignable to type 'TestBedStatic'.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

drackp2m avatar Sep 13 '22 12:09 drackp2m

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Sep 13 '22 12:09 zorro-bot[bot]

Codecov Report

Merging #7637 (59ba163) into master (8e25b50) will decrease coverage by 0.05%. The diff coverage is n/a.

:exclamation: Current head 59ba163 differs from pull request most recent head cc0dce0. Consider uploading reports for the commit cc0dce0 to get more accurate results

@@            Coverage Diff             @@
##           master    #7637      +/-   ##
==========================================
- Coverage   92.09%   92.03%   -0.06%     
==========================================
  Files         502      502              
  Lines       16752    16736      -16     
  Branches     2629     2629              
==========================================
- Hits        15427    15403      -24     
- Misses       1056     1064       +8     
  Partials      269      269              
Impacted Files Coverage Δ
components/core/testing/component-bed.ts 90.90% <ø> (ø)
components/table/src/styled/ellipsis.directive.ts 50.00% <0.00%> (-50.00%) :arrow_down:
...omponents/table/src/styled/word-break.directive.ts 50.00% <0.00%> (-50.00%) :arrow_down:
...omponents/table/src/cell/th-selection.component.ts 23.07% <0.00%> (-7.70%) :arrow_down:
...s/cdk/resize-observer/resize-observer.directive.ts 19.04% <0.00%> (-4.77%) :arrow_down:
components/code-editor/code-editor.component.ts 14.40% <0.00%> (-1.60%) :arrow_down:
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) :arrow_down:
components/affix/affix.component.ts 89.92% <0.00%> (-0.15%) :arrow_down:
components/tree/tree-node.component.ts 93.98% <0.00%> (-0.13%) :arrow_down:
components/modal/modal.component.ts 95.83% <0.00%> (-0.13%) :arrow_down:
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 13 '22 12:09 codecov[bot]

It seems that some tests are not passed, please fix them first :)

simplejason avatar Sep 24 '22 14:09 simplejason

It seems that some tests are not passed, please fix them first :)

simplejason avatar Sep 24 '22 14:09 simplejason