ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

fix(module:select): input field length restricted to 82px

Open LemniscateX opened this issue 2 years ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Every input field in <Select/> component cannot extend its length to the rest of line, and that its length is limited to 82px. Issue Number: #7556

What is the new behavior?

Input field in <Select/> component can stretch to what it should be(with max length equals the max length of the block).

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This problem is introduced by fixing #6209 (which is merged in #6222), and the detailed bugtrace can be found in the comment below. 😂 lol

LemniscateX avatar Sep 05 '22 03:09 LemniscateX

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Sep 05 '22 03:09 zorro-bot[bot]

CI failed because of a type error in components/core/testing/component-bed.ts, which is in master branch, thus I couldn't decide to fix it myself or wait for remote changes 🧐

LemniscateX avatar Sep 05 '22 03:09 LemniscateX

please make sure npm run test works well in your local env :)

simplejason avatar Sep 24 '22 14:09 simplejason

Codecov Report

Merging #7626 (c7fafcd) into master (2cb80fc) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7626      +/-   ##
==========================================
- Coverage   92.02%   92.01%   -0.02%     
==========================================
  Files         502      502              
  Lines       16738    16738              
  Branches     2629     2629              
==========================================
- Hits        15403    15401       -2     
- Misses       1069     1070       +1     
- Partials      266      267       +1     
Impacted Files Coverage Δ
components/select/select-search.component.ts 89.36% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (-0.71%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 25 '22 08:09 codecov[bot]